Cleanup hack/build-and-push.sh #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcarva
approved these changes
May 2, 2024
zregvart
force-pushed
the
pr/cleanup-hack-and-push
branch
from
e65699c to
ceca0a0
Compare
|
/retest |
zregvart
force-pushed
the
pr/cleanup-hack-and-push
branch
from
ceca0a0 to
968a1f5
Compare
simonbaird
approved these changes
May 10, 2024
|
/retest |
When `tkn bundle push` exits with code not equal to 0, due to `errexit` being turned on (`set -e`) the script is terminated immediately without retrying. This changes the logic so if the `tkn bundle push` succeeds the retying while loop is stopped, i.e. the `&& break` branch is executed. In case of errors the `&& break` branch is not executed and the status of `tkn bundle push` is captured in the `status` variable, the retrying `while` loop continues until `max_retries` is reached.
This is to to prevent globs and multiple shell words being interpreted where one is expected.
simonbaird
force-pushed
the
pr/cleanup-hack-and-push
branch
from
968a1f5 to
f434af8
Compare
|
|
I clicked the GitHub button to do a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several issues with the
hack/build-and-push.shscript. See individual commits for details.