-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(STONEINTG-887): get base images from SBOM #954
feat(STONEINTG-887): get base images from SBOM #954
Conversation
Example
|
Example when base images are available in SBOM:
|
4c6c7cc
to
bc19113
Compare
/retest |
b3a1cbd
to
ed40d5d
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ed40d5d
to
4ed8228
Compare
f8e6859
to
da81558
Compare
Reverted to original code using cosign, we couldn't access workspace in parallel due to EBS storage. Also removed unused result, to reuse version bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comment. Others look good to me.
3980e4a
to
8c671c3
Compare
Task `deprecated-image-check` will fetch data about base images also from SBOM. This requires an incompatible change, because users must update PLR definition with the new parameters. In future, konflux will stop provide BASE_IMAGES_DIGESTS via parameter, thus this param is optional now (we cannot remove it yet) Signed-off-by: Martin Basti <[email protected]>
PYXIS_HTTP_CODE result is unused for long time Signed-off-by: Martin Basti <[email protected]>
8c671c3
to
9636c0c
Compare
Quality Gate passedIssues Measures |
Task
deprecated-image-check
will fetch data about base images also from SBOM.This requires incompatible change, because users must update PLR definition with new parameters.
In future, konflux will stop provide BASE_IMAGES_DIGESTS via parameter, thus this param is optional now (we cannot remove it yet)
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.