fix(KFLUXBUGS-1215): fix use of PREFETCH_INPUT #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scoheb
force-pushed
the
build-remote-prefetch
branch
3 times, most recently
from
8e3db06 to
99423df
Compare
chmeliik
reviewed
Apr 18, 2024
- quotes within variable are not handled very well by ssh command and it impacts the buildah-remote task (which is based on this task) we only need to know if prefetch was used, not the actual input. Therefore, we inspect whether cachi2 has been called. Signed-off-by: Scott Hebert <[email protected]>
scoheb
force-pushed
the
build-remote-prefetch
branch
from
99423df to
6dbf835
Compare
|
|
/retest |
chmeliik
reviewed
Apr 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by ssh command and it impacts the buildah-remote task
(which is based on this task)
we only need to know if prefetch was used, not the actual
input. Therefore, we inspect whether cachi2 has been called.