Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable public key path for EC pipelines #938

Merged
merged 6 commits into from
May 21, 2024

Conversation

gbenhaim
Copy link
Member

@gbenhaim gbenhaim commented Apr 14, 2024

Allow to mention the path to the public key in the enterprise-contract pipelines. This is needed when running on non OCP k8s cluster.

@gbenhaim gbenhaim requested a review from lcarva April 14, 2024 08:21
@gbenhaim
Copy link
Member Author

/test

@zregvart
Copy link
Member

For consistency it might make sense to update the other enterprise-contract pipelines

@lcarva
Copy link
Contributor

lcarva commented Apr 15, 2024

Looks reasonable to me besides what Zoran commented.

Allow to mention the path to the public key in the enterprise-contract
pipelines. This is needed when running on non OCP k8s cluster.

Signed-off-by: gbenhaim <[email protected]>
@gbenhaim gbenhaim changed the title Configurable public key path for EC pipeline Configurable public key path for EC pipelines Apr 17, 2024
@gbenhaim
Copy link
Member Author

@lcarva @zregvart done

Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gbenhaim gbenhaim enabled auto-merge April 17, 2024 18:32
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gbenhaim gbenhaim added this pull request to the merge queue May 21, 2024
Merged via the queue into konflux-ci:main with commit 9b2b11c May 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants