new build-args-file parameter which allows to pass build arguments to

[rcerven]

buildah task

KONFLUX-268

Before you complete this pull request ...

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

[chmeliik]

IMO we shouldn't assume the BUILD_ARGS_FILE is relative to the context dir

Suggested change

	BUILDAH_ARGS+=("--build-arg-file=${SOURCE_CODE_DIR}/${CONTEXT}/${BUILD_ARGS_FILE}")
	BUILDAH_ARGS+=("--build-arg-file=${SOURCE_CODE_DIR}/${BUILD_ARGS_FILE}")

Buildah only does this for the Containerfile, not for the build-arg-file

$ mkdir context
$ echo 'FROM scratch' > context/Containerfile
$ buildah build -f Containerfile context/
# works
$ echo foo=bar > context/args.conf
$ buildah build -f Containerfile --build-arg-file args.conf context/
Error: open args.conf: no such file or directory

[rcerven]

but we won't be passing just "args.conf" but full path to the context dir

build args are for component, so using context dir makes sense to me

[chmeliik]

build args are for component, so using context dir makes sense to me

I don't think we have any basis for this. The user may want to pass the same args to all their components or different args to each component.

I would say that making the path relative to the context dir makes things unnecessarily more confusing

- name: path-context
  value: context
- name: build-arg-file
  value: context/args.conf

# =>
# Error: open source/context/context/args.conf: no such file or directory

# Huh? Why is Konflux saying the file doesn't exist? It exists in my repo.

Especially considering that buildah doesn't behave like that (doesn't consider the --build-arg-file as relative to the context dir)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[chmeliik]

LGTM 👍

[rcerven]

I've changed it to " BUILDAH_ARGS+=("--build-arg-file=${SOURCE_CODE_DIR}/${BUILD_ARGS_FILE}")

because that is what I wanted initially do

and it is up to users, if they will provide builargs from the root of the repo "./args.conf", or from context "./context/args.conf"

anyway it is "full" path within repo which will be provided in the --build-arg-file

[rcerven]

/retest