Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle GitLab merge request event in RHTAP pipeline #921

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

mmorhun
Copy link
Collaborator

@mmorhun mmorhun commented Apr 4, 2024

Update deployment task should be skipped in pull request pipeline.
Pipelines as Code has different name of the event for GitHub and GitLab. Take both into account.

@mmorhun mmorhun self-assigned this Apr 4, 2024
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@chmeliik
Copy link
Contributor

chmeliik commented Apr 4, 2024

Pipelines as Code has different name of the event for GitHub and GitLab

Is this documented somewhere or just based on testing?

@mmorhun
Copy link
Collaborator Author

mmorhun commented Apr 4, 2024

@chmeliik I haven't seen it in the docs, just what PaC substantiated for {{event_type}} in case of GitLab and merge request.

@mmorhun mmorhun merged commit b806ca7 into konflux-ci:main Apr 4, 2024
5 of 6 checks passed
@mmorhun mmorhun deleted the RHTAPBUGS-1160-2 branch April 4, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants