hack/build-and-push.sh: fix digest existence check #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmeliik
force-pushed
the
fix-tag-existence-check
branch
from
d33c1a4 to
ae5a584
Compare
chmeliik
changed the title
|
Previous test run failed with a timeout on the EC pipelinerun $ kubectl tekton -n build-templates-e2e get pr ec-integration-test-scenario-run-zq78g
NAME STARTED DURATION STATUS UID
ec-integration-test-scenario-run-zq78g 1 hour ago --- Running 4df9d745-46e0-40bd-b592-631df5bb3aabNot sure what happened there. I can't even get the pipelineRun from Kubernetes, only from the Tekton results DB |
|
/retest just to check that we don't re-push existing tags |
tkdchen
approved these changes
Mar 26, 2024
|
/retest |
chmeliik
force-pushed
the
fix-tag-existence-check
branch
from
cbe8cd1 to
9e4422d
Compare
the hell |
|
/retest |
|
Hmm, same failure again. Need to look into it |
chmeliik
force-pushed
the
fix-tag-existence-check
branch
from
9e4422d to
9800c2a
Compare
|
Timed out while running the build pipeline. It took 47 minutes, but can't really figure out why $ kubectl tekton -n build-templates-e2e get pr devfile-sample-python-basic-lncu-f6lkl
NAME STARTED DURATION STATUS UID
devfile-sample-python-basic-lncu-f6lkl 17 hours ago 46m45s Succeeded(Completed) 584f3d17-87e9-4400-8aae-1a00429cf1de
$ kubectl tekton -n build-templates-e2e logs pr devfile-sample-python-basic-lncu-f6lkl
error: rpc error: code = NotFound desc = Log doesn't exist |
chmeliik
force-pushed
the
fix-tag-existence-check
branch
from
9800c2a to
e4b3e6a
Compare
|
Some of the Tasks from the These seem particularly long. Not sure what would cause those tasks to take over 10 minutes each and to not run in parallel. Maybe hitting some quota in the |
The current check queries Quay's custom API and expects that the tags
in the response always exist. This is not the case for deleted/expired
tags. See for example:
curl 'https://quay.io/api/v1/repository/redhat-appstudio-tekton-catalog/pull-request-builds/tag/?specificTag=buildah-0.1-2f4e137b5ed645c6d5279c52eaf1d20b071729f1'
{
"tags": [
{
"name": "buildah-0.1-2f4e137b5ed645c6d5279c52eaf1d20b071729f1",
"reversion": false,
"start_ts": 1709804197,
"end_ts": 1711038680,
"manifest_digest": "sha256:ebb2fe8fe89005229962167b9a31015a023a49a7169c52edfc34d18fcb1270dd",
"is_manifest_list": false,
"size": 5920,
"last_modified": "Thu, 07 Mar 2024 09:36:37 -0000",
"expiration": "Thu, 21 Mar 2024 16:31:20 -0000"
}
],
"page": 1,
"has_additional": false
}
This tag has expired (and Quay reports it as such), but our script does
not notice that.
Fix the problem by using `skopeo inspect` instead of querying Quay's
custom API.
Signed-off-by: Adam Cmiel <[email protected]>
chmeliik
force-pushed
the
fix-tag-existence-check
branch
from
e4b3e6a to
a508a79
Compare
|
|
Seems like an intermittent issue |
|
/rerun |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current check queries Quay's custom API and expects that the tags in the response always exist. This is not the case for deleted/expired tags. See for example:
This tag has expired (and Quay reports it as such), but our script does not notice that.
Fix the problem by using
skopeo inspectinstead of querying Quay's custom API.Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.