fix(STONEBLD-2265): increase the default timeout of pull-request-type PLR & e2e-tests Task to 2hrs #893
Conversation
There was a problem hiding this comment.
I tried to do something similar in 4243774, but I still saw tests getting interrupted after roughly an hour.
But it looked like a timeout on the ginkgo side, not an openshift timeout. I tried setting the ginkgo.timeout flag but not sure if it did anything
|
@chmeliik konflux-ci/e2e-tests#1091 could this help? |
Hmm, the timeouts I was seeing were not from waiting for the attestation, they looked like overall timeouts for the whole test suite (but coming from ginkgo, not from openshift). I unfortunately don't have the error message saved anywhere, so let's just go ahead with this and see if we hit timeouts again |
dheerajodha
force-pushed
the
STONEBLD-2265
branch
2 times, most recently
from
6ebe771 to
c4fd5df
Compare
dheerajodha
changed the title
|
/retest |
|
@dheerajodha if this round of tests doesn't pass, can you try to combine this PR with #897? I think there's a low chance of passing tests otherwise |
|
Can we just merge it? it only affects tekton definitions and that's working |
dheerajodha
force-pushed
the
STONEBLD-2265
branch
from
f7daf54 to
d1865f8
Compare
Oh nice, done, PTAL. I didn't know that I had to update the image but it makes sense now, thanks for letting me know!
Can we just wait for one last build PLR to finish, please? |
|
Hmm, yeah here's the suite timeout |
|
@dheerajodha oh, I think I found the timeout flag $ ginkgo help ginkgo | grep timeout
--timeout [duration] (default: 1h)
Test suite fails if it does not complete within the specified timeout.Needs to be added to |
Hmm, no, it should be $ podman run --rm -ti quay.io/redhat-appstudio/e2e-tests:c18b86ccadcc8818d8d0e6e07d2dd4e98c7b5af8 --help | grep timeout
--ginkgo.timeout [duration] (default: 1h)
Test suite fails if it does not complete within the specified timeout.
-test.timeout d
panic test binary after duration d (default 0, timeout disabled) |
* This change increases the default timeout (60mins) of the PR-type PLR and the 'e2e-tests' Task to 2hrs. * This is a temporary change, please see: konflux-ci/e2e-tests#1091 * Since the chains controller is overwhelmed, we had to increase the test timeout value to 90mins. * So this current PR increases the timeout values for PLR and a Task to the 2hrs to give enough time for chains as well as other tests to execute within time. Signed-off-by: Dheeraj<[email protected]>
|
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.