-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give write permission to e2e-tests task #883
Give write permission to e2e-tests task #883
Conversation
/retest |
How is that related to the changes in this PR? |
The pull secret has to be written into the default auth file. What I found is, without the capability, it fails to write. |
@tkdchen it would be nice to have the above in PR description. A link to docs or your findings would be a bonus. |
da587f6
to
8ecbb3a
Compare
@mmorhun Updated the commit message, PTAL. Also, rebased. |
Would it be better to change the short commit message as well? Instead of "Run e2e tests to check including parent sources" to "Give the e2e-test task write permissions" or something about updating the permissions? |
STONEBLD-1832 Pull secret is required to be available for the e2e tests in order to fetch image data from registry.redhat.io. The task needs the capability in order to write the registry authentication credential into auth file. Signed-off-by: Chenxiong Qi <[email protected]>
cc03b0f
to
70248f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
Quality Gate passedIssues Measures |
e2e-tests failure
|
STONEBLD-1832
Pull secret is required to be available for the e2e tests in order to
fetch image data from registry.redhat.io. The task needs the capability
in order to write the registry authentication credential into auth file.