Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give write permission to e2e-tests task #883

Merged

Conversation

tkdchen
Copy link
Contributor

@tkdchen tkdchen commented Mar 18, 2024

STONEBLD-1832

Pull secret is required to be available for the e2e tests in order to
fetch image data from registry.redhat.io. The task needs the capability
in order to write the registry authentication credential into auth file.

@tkdchen
Copy link
Contributor Author

tkdchen commented Mar 19, 2024

/retest

@chmeliik
Copy link
Contributor

Pull secret is required to be available for the e2e tests in order to fetch image data from registry.redhat.io.

How is that related to the changes in this PR?

@tkdchen
Copy link
Contributor Author

tkdchen commented Mar 20, 2024

The pull secret has to be written into the default auth file. What I found is, without the capability, it fails to write.

@mmorhun
Copy link
Collaborator

mmorhun commented Mar 21, 2024

@tkdchen it would be nice to have the above in PR description. A link to docs or your findings would be a bonus.

@tkdchen tkdchen force-pushed the STONEBLD-1832-check-including-parent-sources branch 2 times, most recently from da587f6 to 8ecbb3a Compare March 21, 2024 13:32
@tkdchen
Copy link
Contributor Author

tkdchen commented Mar 21, 2024

@mmorhun Updated the commit message, PTAL. Also, rebased.

@mkosiarc
Copy link
Contributor

Would it be better to change the short commit message as well? Instead of "Run e2e tests to check including parent sources" to "Give the e2e-test task write permissions" or something about updating the permissions?

STONEBLD-1832

Pull secret is required to be available for the e2e tests in order to
fetch image data from registry.redhat.io. The task needs the capability
in order to write the registry authentication credential into auth file.

Signed-off-by: Chenxiong Qi <[email protected]>
@tkdchen tkdchen force-pushed the STONEBLD-1832-check-including-parent-sources branch from cc03b0f to 70248f6 Compare March 25, 2024 08:50
@tkdchen tkdchen changed the title Run e2e tests to check including parent sources Give write permission to e2e-tests task Mar 25, 2024
Copy link
Collaborator

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tkdchen
Copy link
Contributor Author

tkdchen commented Mar 27, 2024

/retest

Copy link

sonarqubecloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tkdchen
Copy link
Contributor Author

tkdchen commented Apr 1, 2024

e2e-tests failure

[e2e-tests : e2e-test]   [FAILED] Expected success, but got an error:
[e2e-tests : e2e-test]       <*errors.errorString | 0xc000429b00>: 
[e2e-tests : e2e-test]       pipelineTaskName "clair-scan" not found in PipelineRun fbc-sample-repo-otis-dq9tx/build-templates-e2e
[e2e-tests : e2e-test]       {
[e2e-tests : e2e-test]           s: "pipelineTaskName \"clair-scan\" not found in PipelineRun fbc-sample-repo-otis-dq9tx/build-templates-e2e",
[e2e-tests : e2e-test]       }
[e2e-tests : e2e-test]   In [It] at: /github.com/redhat-appstudio/e2e-tests/tests/build/build_templates.go:372 @ 04/01/24 02:00:45.002
[e2e-tests : e2e-test] ------------------------------
[e2e-tests : e2e-test] SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
[e2e-tests : e2e-test] 

@mmorhun mmorhun merged commit 2f42e64 into konflux-ci:main Apr 1, 2024
5 of 6 checks passed
@tkdchen tkdchen deleted the STONEBLD-1832-check-including-parent-sources branch April 1, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants