RHTAPSRE-405: Custom CA bundle for git-clone #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support custom CA bundle in the git-clone task. Required when cloning using HTTPs from an SCM that has self-signed certificate. Signed-off-by: gbenhaim <[email protected]>
MartinBasti
approved these changes
Feb 28, 2024
|
/test |
chmeliik
reviewed
Mar 4, 2024
|
@chmeliik I didn't find any other way to do it. |
|
@chmeliik here is the openshift documentation I followed https://docs.openshift.com/container-platform/4.14/networking/configuring-a-custom-pki.html#nw-proxy-configure-object_configuring-a-custom-pki |
chmeliik
approved these changes
Mar 4, 2024
Ok. Just beware that other tasks will need corresponding changes too. |
|
|
Technically users could define pod templates in pipeline definition and mount CA there for every pod, but that's not something we should have at task level though. |
|
https://tekton.dev/docs/pipelines/podtemplates/ it seems that volumeMounts are not supported :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support custom CA bundle in the git-clone task.
Required when cloning using HTTPs from an SCM that has self-signed certificate.