Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove references to jvm-build-service #1766

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

remove references to jvm-build-service #1766

wants to merge 5 commits into from

Conversation

tnevrlka
Copy link
Contributor

@tnevrlka tnevrlka commented Dec 19, 2024 •
edited
Loading

  • jvm-build-service is not used by anyone and will get reworked
  • buildah task contains references to jvm-build-service
  • Removal of the references is a breaking change
    • Remove analyse-dependencies-java-sbom step
    • Remove SBOM_JAVA_COMPONENTS_COUNT result
    • Remove JAVA_COMMUNITY_DEPENDENCIES result
  • Release buildah version 0.3
  • Upgrade buildah version in docker-build pipelines to 0.3

Note for reviewers:
I haven't found an easy way to compare different files in GitHub, I would probably checkout the branch locally and do something like:

diff task/buildah/0.2/buildah.yaml task/buildah/0.3/buildah.yaml

(I welcome different ideas)

@tnevrlka tnevrlka requested a review from a team as a code owner December 19, 2024 09:57
@tnevrlka tnevrlka marked this pull request as draft December 19, 2024 10:00
@tnevrlka tnevrlka force-pushed the remove-jvm-build-service branch from 36cc05c to be37461 Compare December 19, 2024 10:05
@chmeliik
Copy link
Contributor

Note for reviewers: I haven't found an easy way to compare different files in GitHub, I would probably checkout the branch locally and do something like:

diff task/buildah/0.2/buildah.yaml task/buildah/0.3/buildah.yaml

(I welcome different ideas)

My favourite approach is this:

  • 1st commit: copy buildah/0.2 to buildah/0.3 with absolutely no changes
  • 2nd commit: make your changes

This also works beautifully with rebasing on main. If buildah/0.2 changes in the meantime, you just fix the first commit by running cp again and git usually reapplies the changes from the second commit correctly after that.

@tnevrlka tnevrlka force-pushed the remove-jvm-build-service branch 2 times, most recently from 08dcf4e to c325e83 Compare December 19, 2024 15:47
@tnevrlka tnevrlka marked this pull request as ready for review December 19, 2024 15:50
chmeliik
chmeliik reviewed Dec 20, 2024
View reviewed changes
task/buildah/0.3/MIGRATION.md Show resolved Hide resolved
task/buildah-oci-ta/0.3/MIGRATION.md Outdated

Removes references to `jvm-build-service`
* Removes `analyse-dependencies-java-sbom` step
* Removes `SBOM_JAVA_COMPONENTS_COUNT` and `JAVA_COMMUNITY_DEPENDENCIES` results
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(similarly for the other migrations)

@chmeliik
Copy link
Contributor

Could you also update https://github.com/konflux-ci/build-definitions/blob/main/.github/workflows/temp-block-buildah.yaml to also check the 0.3 yaml?

It appears that the check is still relevant, no updates on https://issues.redhat.com/browse/KONFLUX-5706 😞

@tnevrlka
create scaffolding for buildah 0.3
d4464a0 
- Buildah 0.3 will be released
- Copy buildah 0.2 directory to 0.3 for easier diff comparisons between the versions
@tnevrlka
remove references to jvm-build-service
d05bf6a 
- jvm-build-service is not used by anyone and will get reworked
- buildah task contains references to jvm-build-service
- Removal of the references is a breaking change
  * Remove `analyse-dependencies-java-sbom` step
  * Remove `SBOM_JAVA_COMPONENTS_COUNT` result
  * Remove `JAVA_COMMUNITY_DEPENDENCIES` result
- Release buildah version 0.3
@tnevrlka
upgrade buildah remote and ta tasks to 0.3
42611c4 
- Buildah task has been upgraded to 0.3
- Upgrade the oci-ta and remote tasks too
@tnevrlka tnevrlka force-pushed the remove-jvm-build-service branch 2 times, most recently from e0bd08f to 4e5729d Compare December 20, 2024 09:48
@tnevrlka
block buildah-remote-oci-ta size increase for 0.3
07064c0 
- There is a check ensuring that the size buildah-remote-oci-ta doesn't increase
- It only works for version 0.2, make it work for 0.3 too
@tnevrlka
upgrade docker-build pipelines to use buildah 0.3
b7713d2 
- Buildah task has been updated to 0.3
- Make docker-build pipelines use the new version
@tnevrlka tnevrlka force-pushed the remove-jvm-build-service branch from 4e5729d to b7713d2 Compare December 20, 2024 09:50
chmeliik
chmeliik approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmeliik chmeliik chmeliik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tnevrlka @chmeliik