Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KONFLUX-3935) Add pruning check to FBC pipeline #1744

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nmars
Copy link

@nmars nmars commented Dec 10, 2024

Adds a new task to the fbc-builder pipeline to check if the incoming FBC fragment would remove channels or channel entries already present in the target index.

@nmars nmars requested review from a team as code owners December 10, 2024 21:32
@nmars nmars force-pushed the add-fbc-pruning-check branch from ce58f08 to ad0b49a Compare December 11, 2024 16:45
@nmars nmars force-pushed the add-fbc-pruning-check branch from ad0b49a to 43f2f6c Compare December 11, 2024 17:42
Copy link
Contributor

@MartinBasti MartinBasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving CODEOWNERS change only

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise but needs rebase and resolving the CODEOWNERS conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants