Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create bundle repos automatically if missing #1604

Merged

Conversation

tnevrlka
Copy link
Contributor

@tnevrlka tnevrlka commented Nov 13, 2024

  • A check is currently ran checking that every task bundle has its own
    Quay repository
  • If the task bundle does not have its own repository, the check will
    fail and the repository has to be created manually
  • Automate the repository creation via a task, but only in the on-push
    pipelinerun (once a PR is approved and merged) for security reasons

@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from 1091329 to 22984b7 Compare November 13, 2024 13:35
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from 22984b7 to df0405c Compare November 14, 2024 14:09
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from df0405c to 515af32 Compare November 18, 2024 09:20
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from 515af32 to c715d41 Compare November 22, 2024 11:46
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from c715d41 to ed1dd8e Compare November 22, 2024 12:07
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from ed1dd8e to 06be9f4 Compare November 22, 2024 12:22
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from 06be9f4 to 0a481e2 Compare November 22, 2024 12:35
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from 0a481e2 to efff767 Compare November 22, 2024 13:07
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from efff767 to b828c7f Compare November 22, 2024 14:16
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from b828c7f to 3b9dd78 Compare November 25, 2024 09:26
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from 3b9dd78 to 79646c6 Compare November 25, 2024 10:18
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from 79646c6 to 5402e54 Compare December 4, 2024 13:15
@tnevrlka
Copy link
Contributor Author

tnevrlka commented Dec 4, 2024

/retest

@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from 5402e54 to bc362a5 Compare December 4, 2024 16:49
@tnevrlka tnevrlka marked this pull request as ready for review December 5, 2024 08:38
@openshift-ci openshift-ci bot requested review from eskultety and mmorhun December 5, 2024 08:38
@tnevrlka tnevrlka requested a review from chmeliik December 5, 2024 08:38
.tekton/push.yaml Show resolved Hide resolved
.tekton/scripts/create-task-pipeline-bundle-repos.sh Outdated Show resolved Hide resolved
.tekton/scripts/create-task-pipeline-bundle-repos.sh Outdated Show resolved Hide resolved
.tekton/scripts/create-task-pipeline-bundle-repos.sh Outdated Show resolved Hide resolved
--arg repository "$quay_repo_prefix/$object" \
--arg visibility "public" \
--arg description "" \
'$ARGS.named'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, didn't know about $ARGS.named 🌮

.tekton/scripts/create-task-pipeline-bundle-repos.sh Outdated Show resolved Hide resolved
@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from bc362a5 to 6091d21 Compare December 6, 2024 09:33
@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch 2 times, most recently from 12068b9 to c405106 Compare December 6, 2024 13:37
- A check is currently ran checking that every task bundle has its own
  Quay repository
- If the task bundle does not have its own repository, the check will
  fail and the repository has to be created manually
- Automate the repository creation via a task, but only in the on-push
  pipelinerun (once a PR is approved and merged) for security reasons
@tnevrlka tnevrlka force-pushed the create-bundle-repos-automatically branch from c405106 to 43cb5cc Compare December 6, 2024 19:08
@tnevrlka tnevrlka requested a review from a team as a code owner December 6, 2024 19:08
@tnevrlka tnevrlka added this pull request to the merge queue Dec 9, 2024
Merged via the queue into konflux-ci:main with commit f642cd3 Dec 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants