sast-unicode-check: add support for Trusted Artifacts #1524

kdudka · 2024-10-21T14:03:12Z

Create the -oci-ta variant of the sast-unicode-check task.

Related: #1401
Resolves: https://issues.redhat.com/browse/OSH-764

kdudka · 2024-10-21T14:03:34Z

/ok-to-test

rhyw · 2024-10-22T13:15:00Z

@kdudka The script doesn't take care of the OWNERS files though. Still need to add manually.

kdudka · 2024-10-23T08:10:07Z

@rhyw Added. Thanks for the notice!

Before this change, the `sast-unicode-check` was failing with the default parameters because the script was passing the whole list of arguments as a single argument: ``` + mapfile -t fuc_args + LANG=en_US.utf8 + ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source + FUC_EXIT_CODE=2 + [[ 2 -ne 0 ]] + [[ 2 -ne 1 ]] + echo 'Failed to run find-unicode-control command' Failed to run find-unicode-control command + cat raw_sast_unicode_check_out.log usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG] path [path ...] find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi') + note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.' ++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.' ``` Fixes: konflux-ci#1401 Related: konflux-ci#1524

Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524

kdudka · 2024-10-24T08:18:44Z

I have tested this via https://github.com/kdudka/konflux-test-ec-cli/pull/1/checks?check_run_id=31993329561.

Before this change, the `sast-unicode-check` was failing with the default parameters because the script was passing the whole list of arguments as a single argument: ``` + mapfile -t fuc_args + LANG=en_US.utf8 + ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source + FUC_EXIT_CODE=2 + [[ 2 -ne 0 ]] + [[ 2 -ne 1 ]] + echo 'Failed to run find-unicode-control command' Failed to run find-unicode-control command + cat raw_sast_unicode_check_out.log usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG] path [path ...] find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi') + note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.' ++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.' ``` Fixes: konflux-ci#1401 Related: konflux-ci#1524

Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524

Before this change, the `sast-unicode-check` was failing with the default parameters because the script was passing the whole list of arguments as a single argument: ``` + mapfile -t fuc_args + LANG=en_US.utf8 + ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source + FUC_EXIT_CODE=2 + [[ 2 -ne 0 ]] + [[ 2 -ne 1 ]] + echo 'Failed to run find-unicode-control command' Failed to run find-unicode-control command + cat raw_sast_unicode_check_out.log usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG] path [path ...] find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi') + note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.' ++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.' ``` Fixes: konflux-ci#1401 Related: konflux-ci#1524

Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524

kdudka · 2024-11-07T12:15:41Z

@hongweiliu17 @tkdchen This CI job has been running for more than 24 hours. Could you please check what happened?

hongweiliu17 · 2024-11-08T06:56:28Z

@hongweiliu17 @tkdchen This CI job has been running for more than 24 hours. Could you please check what happened?

Don't know why the PLR has been deleted but not written back to git provider. Maybe it is caused by the outage. Let's retest it.

BTW: You may request permission to the workspace konflux-ci to check the result.

hongweiliu17 · 2024-11-08T06:56:33Z

/retest

kdudka · 2024-11-08T07:29:39Z

BTW: You may request permission to the workspace konflux-ci to check the result.

When I click any link in the CI results, I can only see this:

There is no link to request access. I found an Access Request form at https://console.redhat.com/internal but I do not know Account number and Organization ID that should be put into this form. Using my own numbers resulted in the following failure:

Before this change, the `sast-unicode-check` was failing with the default parameters because the script was passing the whole list of arguments as a single argument: ``` + mapfile -t fuc_args + LANG=en_US.utf8 + ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source + FUC_EXIT_CODE=2 + [[ 2 -ne 0 ]] + [[ 2 -ne 1 ]] + echo 'Failed to run find-unicode-control command' Failed to run find-unicode-control command + cat raw_sast_unicode_check_out.log usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG] path [path ...] find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi') + note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.' ++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.' ``` Fixes: konflux-ci#1401 Related: konflux-ci#1524

Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524

Before this change, the `sast-unicode-check` was failing with the default parameters because the script was passing the whole list of arguments as a single argument: ``` + mapfile -t fuc_args + LANG=en_US.utf8 + ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source + FUC_EXIT_CODE=2 + [[ 2 -ne 0 ]] + [[ 2 -ne 1 ]] + echo 'Failed to run find-unicode-control command' Failed to run find-unicode-control command + cat raw_sast_unicode_check_out.log usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG] path [path ...] find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi') + note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.' ++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.' ``` Fixes: konflux-ci#1401 Related: konflux-ci#1524

Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524

hongweiliu17 · 2024-11-21T06:50:41Z

/retest

kdudka · 2024-11-21T07:58:08Z

@hongweiliu17 There was a successful CI run yesterday: https://github.com/konflux-ci/build-definitions/runs/33305152289

How come it is now red again?

tkdchen

LGTM generally. It's hard for me to review the logic of the script implementation since I'm not in the specific field.

kdudka · 2024-11-22T07:34:19Z

sast-unicode-check-oci-ta is generated from sast-unicode-check using the hack/generate-ta-tasks.sh script.

task/sast-unicode-check-oci-ta/0.1/README.md

Before this change, the `sast-unicode-check` was failing with the default parameters because the script was passing the whole list of arguments as a single argument: ``` + mapfile -t fuc_args + LANG=en_US.utf8 + ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source + FUC_EXIT_CODE=2 + [[ 2 -ne 0 ]] + [[ 2 -ne 1 ]] + echo 'Failed to run find-unicode-control command' Failed to run find-unicode-control command + cat raw_sast_unicode_check_out.log usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG] path [path ...] find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi') + note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.' ++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.' ``` Fixes: konflux-ci#1401 Related: konflux-ci#1524

... instead of PROJECT_NVR to make the interface compatible with the sast-shell-check task. Related: konflux-ci#1524

Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524

task/sast-unicode-check-oci-ta/0.1/sast-unicode-check-oci-ta.yaml

hongweiliu17 · 2024-11-26T09:55:36Z

Comment for exit 1 according to https://github.com/konflux-ci/architecture/blob/main/ADR/0014-let-pipelines-proceed.md#decision. Others look good to me. ---- Igore this, trap can catch it.
It is better to test the task before merging in case any issues.

hongweiliu17

lgtm

dirgim

LGTM code-wise

kdudka · 2024-12-02T09:49:18Z

I can see this is approved and CI checks are all green. @14rcole Could we please proceed with merging this?

Before this change, the `sast-unicode-check` was failing with the default parameters because the script was passing the whole list of arguments as a single argument: ``` + mapfile -t fuc_args + LANG=en_US.utf8 + ./find-unicode-control/find_unicode_control.py '-p bidi -v -d -t' /var/workdir/source + FUC_EXIT_CODE=2 + [[ 2 -ne 0 ]] + [[ 2 -ne 1 ]] + echo 'Failed to run find-unicode-control command' Failed to run find-unicode-control command + cat raw_sast_unicode_check_out.log usage: find_unicode_control.py [-h] [-p {all,bidi}] [-v] [-d] [-t] [-c CONFIG] path [path ...] find_unicode_control.py: error: argument -p/--nonprint: invalid choice: ' bidi -v -d -t' (choose from 'all', 'bidi') + note='Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.' ++ make_result_json -r ERROR -t 'Task sast-unicode-check-oci-ta failed: For details, check Tekton task log.' ``` Fixes: #1401 Related: #1524

... instead of PROJECT_NVR to make the interface compatible with the sast-shell-check task. Related: #1524

kdudka force-pushed the sast-unicode-check-oci-ta branch from 9e60dab to 838778b Compare October 23, 2024 08:09

kdudka force-pushed the sast-unicode-check-oci-ta branch from 838778b to 31de817 Compare October 24, 2024 08:16

kdudka marked this pull request as ready for review October 24, 2024 08:18

openshift-ci bot requested review from hongweiliu17 and tkdchen October 24, 2024 08:18

kdudka force-pushed the sast-unicode-check-oci-ta branch from 31de817 to 00a6289 Compare October 24, 2024 08:40

kdudka mentioned this pull request Nov 4, 2024

sast: Fix sast unicode check #1535

Closed

kdudka force-pushed the sast-unicode-check-oci-ta branch from 00a6289 to 4a91952 Compare November 6, 2024 09:13

kdudka force-pushed the sast-unicode-check-oci-ta branch from 4a91952 to d2836e2 Compare November 6, 2024 09:34

kdudka force-pushed the sast-unicode-check-oci-ta branch from d2836e2 to 7b71a19 Compare November 11, 2024 09:29

kdudka force-pushed the sast-unicode-check-oci-ta branch from 7b71a19 to 424fdf9 Compare November 13, 2024 09:29

kdudka force-pushed the sast-unicode-check-oci-ta branch from f97c593 to dd54e7c Compare November 20, 2024 13:42

kdudka force-pushed the sast-unicode-check-oci-ta branch from dd54e7c to 8e31162 Compare November 20, 2024 15:06

tkdchen reviewed Nov 22, 2024

View reviewed changes

14rcole reviewed Nov 22, 2024

View reviewed changes

task/sast-unicode-check-oci-ta/0.1/README.md Outdated Show resolved Hide resolved

kdudka added 3 commits November 25, 2024 13:14

sast-unicode-check: take the PROJECT_NAME parameter

b18c220

... instead of PROJECT_NVR to make the interface compatible with the sast-shell-check task. Related: konflux-ci#1524

sast-unicode-check: add support for Trusted Artifacts

97f438b

Create the `-oci-ta` variant of the `sast-unicode-check` task. Related: konflux-ci#1401 Resolves: https://issues.redhat.com/browse/OSH-764 Closes: konflux-ci#1524

kdudka force-pushed the sast-unicode-check-oci-ta branch from 0b645f6 to 97f438b Compare November 25, 2024 12:54

kdudka requested review from 14rcole and tkdchen November 25, 2024 12:56

hongweiliu17 reviewed Nov 26, 2024

View reviewed changes

task/sast-unicode-check-oci-ta/0.1/sast-unicode-check-oci-ta.yaml Show resolved Hide resolved

hongweiliu17 self-requested a review November 26, 2024 10:42

hongweiliu17 approved these changes Nov 26, 2024

View reviewed changes

dirgim approved these changes Nov 27, 2024

View reviewed changes

Merge branch 'main' into sast-unicode-check-oci-ta

aee013e

jperezdealgaba mentioned this pull request Nov 29, 2024

template-build: updated sast tasks #1661

Merged

dirgim added this pull request to the merge queue Dec 2, 2024

github-merge-queue bot pushed a commit that referenced this pull request Dec 2, 2024

sast-unicode-check: take the PROJECT_NAME parameter

9f15437

... instead of PROJECT_NVR to make the interface compatible with the sast-shell-check task. Related: #1524

Merged via the queue into konflux-ci:main with commit c9d0d5c Dec 2, 2024
15 checks passed

rh-tap-build-team bot mentioned this pull request Dec 2, 2024

build-definitions update redhat-appstudio/infra-deployments#4994

Closed

kdudka deleted the sast-unicode-check-oci-ta branch December 2, 2024 10:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sast-unicode-check: add support for Trusted Artifacts #1524

sast-unicode-check: add support for Trusted Artifacts #1524

kdudka commented Oct 21, 2024

kdudka commented Oct 21, 2024

rhyw commented Oct 22, 2024

kdudka commented Oct 23, 2024

kdudka commented Oct 24, 2024

kdudka commented Nov 7, 2024

hongweiliu17 commented Nov 8, 2024

hongweiliu17 commented Nov 8, 2024

kdudka commented Nov 8, 2024

hongweiliu17 commented Nov 21, 2024

kdudka commented Nov 21, 2024

tkdchen left a comment

kdudka commented Nov 22, 2024

hongweiliu17 commented Nov 26, 2024 •

edited

Loading

hongweiliu17 left a comment

dirgim left a comment

kdudka commented Dec 2, 2024

sast-unicode-check: add support for Trusted Artifacts #1524

sast-unicode-check: add support for Trusted Artifacts #1524

Conversation

kdudka commented Oct 21, 2024

kdudka commented Oct 21, 2024

rhyw commented Oct 22, 2024

kdudka commented Oct 23, 2024

kdudka commented Oct 24, 2024

kdudka commented Nov 7, 2024

hongweiliu17 commented Nov 8, 2024

hongweiliu17 commented Nov 8, 2024

kdudka commented Nov 8, 2024

hongweiliu17 commented Nov 21, 2024

kdudka commented Nov 21, 2024

tkdchen left a comment

Choose a reason for hiding this comment

kdudka commented Nov 22, 2024

hongweiliu17 commented Nov 26, 2024 • edited Loading

hongweiliu17 left a comment

Choose a reason for hiding this comment

dirgim left a comment

Choose a reason for hiding this comment

kdudka commented Dec 2, 2024

hongweiliu17 commented Nov 26, 2024 •

edited

Loading