Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rhtap: fix update-deployment condition #1452

Merged
merged 1 commit into from
Sep 20, 2024
+4 −2
Merged

rhtap: fix update-deployment condition #1452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pipelines/docker-build-rhtap/patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,10 @@
- update-deployment
when:
- input: "$(params.event-type)"
operator: notin
values: ["pull_request", "Merge Request"]
operator: in
values:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a value in the list for incoming request (pipeline rerun?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find a specific event type for that, let me check again

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the PaC docs here:

kind: PipelineRun
metadata:
  annotations:
    pipelinesascode.tekton.dev/on-event: "[incoming]"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don't really understand how the incoming requests work. Since the RHTAP PipelineRun are configured with on-event: ["push"], would they even trigger for an incoming request? Can we assume that an incoming request is for a push pipeline, not a PR pipeline? And does RHTAP ever send any incoming requests?

TLDR, I would rather not add it by default

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if RHTAP uses it. With exclude PR events it was theoretically working.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True... well, let's see what happens

- "push" # all providers other than gitlab
- "Push" # gitlab
taskRef:
kind: Task
name: acs-deploy-check
Expand Down
Loading