Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KFLUXBUGS-1601): use the base image name label to get its tag #1448

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

dirgim
Copy link
Contributor

@dirgim dirgim commented Sep 19, 2024

  • The BASE_IMAGE result from the inspect-image task is supposed to be referenced by digest and is supposed to be used as such in other checks within the fbc-validation task
  • Switch to extracting the base image name from the org.opencontainers.image.base.name for the needs of getting the base image tag and deriving the OCP version from it

Signed-off-by: dirgim [email protected]

Before you complete this pull request ...

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

* The prviouslt used BASE_IMAGE result from the inspect-image task
  is supposed to be referenced by digest and is supposed to be
  used as such in other checks within the fbc-validation task
* Switch to extracting the base image name from the
  org.opencontainers.image.base.name for the needs of getting the
  base image tag and deriving the OCP version from it

Signed-off-by: dirgim <[email protected]>

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED
@dirgim
Copy link
Contributor Author

dirgim commented Sep 19, 2024

@grokspawn fyi, feel free to share your thoughts

@kasemAlem kasemAlem self-requested a review September 19, 2024 09:10
Copy link
Contributor

@hongweiliu17 hongweiliu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dirgim dirgim added this pull request to the merge queue Sep 24, 2024
Merged via the queue into konflux-ci:main with commit bbdfbc4 Sep 24, 2024
13 checks passed
@arewm
Copy link
Member

arewm commented Sep 24, 2024

@dirgim, someone has reported seeing an error that looks like it is caused by this change.

jq: error: Could not open file ../inspect-image/image_inspect.json: No such file or directory
Could not get labels from inspect-image/image_inspect.json. Make sure file exists and it contains this label: org.opencontainers.image.base.name
{"result":"ERROR","timestamp":"2024-09-24T17:50:55+00:00","note":"For details, check Tekton task log.","namespace":"default","successes":0,"failures":0,"warnings":0}

@hongweiliu17
Copy link
Contributor

hongweiliu17 commented Sep 25, 2024

@dirgim, someone has reported seeing an error that looks like it is caused by this change.

jq: error: Could not open file ../inspect-image/image_inspect.json: No such file or directory
Could not get labels from inspect-image/image_inspect.json. Make sure file exists and it contains this label: org.opencontainers.image.base.name
{"result":"ERROR","timestamp":"2024-09-24T17:50:55+00:00","note":"For details, check Tekton task log.","namespace":"default","successes":0,"failures":0,"warnings":0}

@dirgim committed a fix #1464 to fix it.

@grokspawn
Copy link
Contributor

Hi @dirgim. I was on PTO when this went out, but it LGTM. Thanks for resolving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants