buildah: restore exclusion of "FROM oci-archive:" #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit f12435b (Replace grep base images parsing with dockerfile-json) accidentally reverted fdc3d9c (buildah: Don't include oci-archive: FROM lines in BASE_IMAGES) Original commit message: In certain cases, we might have a FROM line which is from an archive exported by a pevious build stage; when we are pre-pulling images for a hermetic build, skip these images. (Even if the oci-archive wasn't generated during the build, there's no point in pre-pulling a local URL.) See konflux-ci#1158 Signed-off-by: Owen W. Taylor <[email protected]>
chmeliik
approved these changes
Sep 18, 2024
|
/ok-to-test |
|
/retest |
mkosiarc
approved these changes
Sep 18, 2024
mkosiarc
approved these changes
Sep 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit f12435b (Replace grep base images parsing with dockerfile-json) accidentally reverted fdc3d9c (buildah: Don't include oci-archive: FROM lines in BASE_IMAGES)
Original commit message:
See #1158