-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
download-sbom: make auth work with curl < 7.83.0 #1286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curl versions lower than 7.83.0 do not support the %header{...} syntax. Write out all the headers and pick out the one we need using sed. Signed-off-by: Adam Cmiel <[email protected]>
- declare and assign separately to avoid masking return value (ShellCheck warning) - use a template for the tempfile name to make it identifiable when running the script locally Signed-off-by: Adam Cmiel <[email protected]>
Tested as follows: yq < task/download-sbom-from-url-in-attestation/0.1/download-sbom-from-url-in-attestation.yaml '.spec.steps[1].script' |
sed -e 's/^jq .*/download_blob "$1" "$2"/' -e '/^download_blob "/q' > /tmp/download-blob.sh
podman run --rm -ti -v "/tmp/download-blob.sh:/tmp/download-blob.sh:z" quay.io/konflux-ci/appstudio-utils:ab6b0b8e40e440158e7288c73aff1cf83a2cc8a9@sha256:24179f0efd06c65d16868c2d7eb82573cce8e43533de6cea14fec3b7446e0b14 \
bash /tmp/download-blob.sh ghcr.io/chmeliik/checkton@sha256:00f15a577971426bfbc5f08057f3d4caa6104648acf8b459b4d208f342d4fb1c /dev/null Output on main:
Output here:
|
I gave the My www_authenticate header looks like this:
It finds the auth:
And correctly downloads a blob:
Sanity check the downloaded file:
|
simonbaird
reviewed
Aug 12, 2024
|
||
if [[ "$response_code" -eq 200 ]]; then | ||
# Blob download didn't require auth, we're done | ||
: | ||
elif [[ "$response_code" -eq 401 ]]; then | ||
echo "Got 401, trying to authenticate" >&2 | ||
|
||
local www_authenticate | ||
www_authenticate=$(sed -n 's/^www-authenticate:\s*//ip' "$headers_file") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
simonbaird
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHTAPBUGS-1289
Curl versions lower than 7.83.0 do not support the %header{...} syntax.
Write out all the headers and pick out the one we need using sed.