-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ssh keepalives into buildah-remote to prevent (or at least debug) the ssh conection interruptions #1274
Conversation
@chmeliik @brianwcook pls TAL |
Signed-off-by: Max Shaposhnyk <[email protected]>
d8a110b
to
503d795
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to update the task-generator/remote
tool to generate the remote tasks with this change. While we may get rid of it soon, we still use it, so without updating it your changes will be lost when the next person comes along and runs it.
@ifireball yes i figured that out and did so, please make sure you're on the latest version :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok,
/lgtm
/retest-required |
It is reported some ssh conection interruptions during the long running remote build tasks. It is not yet 100% clear what causes it, but sending those keepalives might help to keep the channel up, or understood which side is closing the connections.
See https://issues.redhat.com/browse/KFLUXBUGS-1523 for more details