Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssh keepalives into buildah-remote to prevent (or at least debug) the ssh conection interruptions #1274

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

mshaposhnik
Copy link
Contributor

@mshaposhnik mshaposhnik commented Aug 9, 2024

It is reported some ssh conection interruptions during the long running remote build tasks. It is not yet 100% clear what causes it, but sending those keepalives might help to keep the channel up, or understood which side is closing the connections.
See https://issues.redhat.com/browse/KFLUXBUGS-1523 for more details

@mshaposhnik mshaposhnik changed the title Add ssh keepalives to prevent (or at least debug) the ssh conection interruptions Add ssh keepalives into buildah-remote to prevent (or at least debug) the ssh conection interruptions Aug 9, 2024
@mshaposhnik
Copy link
Contributor Author

@chmeliik @brianwcook pls TAL

Copy link
Member

@ifireball ifireball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update the task-generator/remote tool to generate the remote tasks with this change. While we may get rid of it soon, we still use it, so without updating it your changes will be lost when the next person comes along and runs it.

@mshaposhnik
Copy link
Contributor Author

@ifireball yes i figured that out and did so, please make sure you're on the latest version :)

Copy link
Member

@ifireball ifireball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,
/lgtm

@mshaposhnik
Copy link
Contributor Author

/retest-required

@chmeliik chmeliik added this pull request to the merge queue Aug 13, 2024
Merged via the queue into konflux-ci:main with commit 9a666b2 Aug 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants