Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User configurable timeout for EaaS cluster provisioning #1259

Merged
merged 2 commits into from
Aug 8, 2024
Merged

User configurable timeout for EaaS cluster provisioning #1259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6809c2
User configurable timeout for EaaS cluster provisioning
amisstea Aug 6, 2024
c27fd40
Resolve checkton errors
amisstea Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion stepactions/eaas-create-ephemeral-cluster-hypershift-aws/0.1/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ This StepAction provisions an ephemeral cluster using Hypershift with 3 worker n
|version|The version of OpenShift to install. Container images will be pulled from: `quay.io/openshift-release-dev/ocp-release:${version}-multi`.||true|
|instanceType|AWS EC2 instance type for worker nodes. Supported values: `m5.large`, `m5.xlarge`, `m5.2xlarge`, `m6g.large`, `m6g.xlarge`, `m6g.2xlarge`|m6g.large|false|
|insecureSkipTLSVerify|Skip TLS verification when accessing the EaaS hub cluster. This should not be set to "true" in a production environment.|false|false|
|timeout|How long to wait for cluster provisioning to complete.|30m|false|

## Results
|name|description|
|---|---|
|clusterName|The name of the generated ClusterTemplateInstance resource|
|clusterName|The name of the generated ClusterTemplateInstance resource.|

14 changes: 11 additions & 3 deletions ...te-ephemeral-cluster-hypershift-aws/0.1/eaas-create-ephemeral-cluster-hypershift-aws.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ spec:
description: >-
Skip TLS verification when accessing the EaaS hub cluster.
This should not be set to "true" in a production environment.
- name: timeout
type: string
default: 30m
description: How long to wait for cluster provisioning to complete.
results:
- name: clusterName
description: The name of the generated ClusterTemplateInstance resource.
Expand All @@ -45,6 +49,8 @@ spec:
key: kubeconfig
- name: INSECURE_SKIP_TLS_VERIFY
value: "$(params.insecureSkipTLSVerify)"
- name: TIMEOUT
value: "$(params.timeout)"
script: |
#!/bin/bash
set -eo pipefail
Expand All @@ -61,6 +67,8 @@ spec:
value: $INSTANCE_TYPE
- name: version
value: $VERSION
- name: timeout
value: $TIMEOUT
EOF

trap 'rm -f "$KUBECONFIG"' EXIT
Expand All @@ -71,12 +79,12 @@ spec:
echo "Created ClusterTemplateInstance $CTI_NAME"
echo -n $CTI_NAME > $(step.results.clusterName.path)

echo "Waiting for ClusterTemplateInstance to be ready (20m timeout)"
if "${OC[@]}" wait cti $CTI_NAME --for=jsonpath='{.status.phase}'=Ready --timeout=20m; then
echo "Waiting for ClusterTemplateInstance to be ready ($TIMEOUT timeout)"
if "${OC[@]}" wait cti "$CTI_NAME" --for=jsonpath='{.status.phase}'=Ready --timeout="$TIMEOUT"; then
echo "Successfully provisioned $CTI_NAME"
exit 0
else
"${OC[@]}" get cti $CTI_NAME -o yaml
"${OC[@]}" get cti "$CTI_NAME" -o yaml
echo "Failed to provision $CTI_NAME"
exit 1
fi
Loading