-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(KONFLUX-1503): Set some requests and limits so pods can spread across cluster nodes #1247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I do not know about the changes to the computeResources specifically, I don't have an issue with this change if it will improve the behavior and performance of the clusters (i.e. improved auto-scaling).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@jhutar Can you rebase the PR |
Fixed a typo found by PR checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add resource request only to the task and not steps for sake of all us :)
Hello @rcerven . For sake of me, please could you give more info on why? I assume you meant this functionality: https://tekton.dev/docs/pipelines/compute-resources/#task-level-compute-resources-configuration but it is marked as Beta, so not sure if it is OK to use it. I think it is better to use more granular settings. You are concerned about maintainability of these settings? If I read the docs for Task-level resources feature correctly:
all the containers will run with whatever I configure on Task-level, so if I would use 1/2Gi requests (as that is biggest one used for I'm happy to do so as it will just mean more compute plane nodes created by node autoscaler and better distribution of tasks, but I thought what I propose is already big change. Also I would like to be sure it is a general consensus before doing these changes. |
FYI rebased. |
Let the Konflux team manage these resources as they seem to be on track of doing that konflux-ci/build-definitions#1247
Let the Konflux team manage these resources as they seem to be on track of doing that konflux-ci/build-definitions#1247
Let the Konflux team manage these resources as they seem to be on track of doing that konflux-ci/build-definitions#1247
Let the Konflux team manage these resources as they seem to be on track of doing that konflux-ci/build-definitions#1247
Let the Konflux team manage these resources as they seem to be on track of doing that konflux-ci/build-definitions#1247
Let the Konflux team manage these resources as they seem to be on track of doing that konflux-ci/build-definitions#1247
Let the Konflux team manage these resources as they seem to be on track of doing that konflux-ci/build-definitions#1247
Let the Konflux team manage these resources as they seem to be on track of doing that konflux-ci/build-definitions#1247
Let the Konflux team manage these resources as they seem to be on track of doing that konflux-ci/build-definitions#1247
IMO this needs to happen before redhat-appstudio/infra-deployments#4275
Some support for these values: https://docs.google.com/document/d/1SvR7AP1UCU67bV0UvYhn6b8U30LCoPu9zcD5Wd1uAxk/edit?pli=1#heading=h.7kx4nf5n5g