Use a var for the images file path in the RHTAP gather-deploy-images task #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short explanation: Clean up the code a little by using a variable. Long explanation: This task gets converted to a bash script and wrapped by a Jenkins shared library in the brand new RHTAP Jenkins pipeline sample templates. When testing the RHTAP Jenkins pipeline I found the default Jenkins user could not write to /tmp/, so I wanted to change the location of the file. This refactor makes that just a single line change, rather than having to change the path in three places. See also redhat-appstudio/tssc-sample-jenkins#1 where this PR was suggested by @mmorhun, and also redhat-appstudio/tssc-dev-multi-ci#2 where the cosign, Enterprise Contract, and promote pipeline support was being added to the RHTAP Jenkins templates.
simonbaird
added a commit
to simonbaird/tssc-dev-multi-ci
that referenced
this pull request
Aug 5, 2024
- Do some handling of the Rekor options - Pull in the public key from the environment var created from the credential as it is done in the build pipeline. - Fix some bash typos and syntax errors - Use a different location for the /tmp/all-images.txt since my Jenkins user was not permitted to write to /tmp. - Add a way to provide your own list of images to verify to help debug the ec verification. - Use github url for configuration instead of a named ECP cluster record See also konflux-ci/build-definitions#1240 which back-ports one of the changes introduced here to the original source of the gather-deploy-images task. Ref: https://issues.redhat.com/browse/EC-745
simonbaird
added a commit
to simonbaird/tssc-dev-multi-ci
that referenced
this pull request
Aug 5, 2024
- Do some handling of the Rekor options - Pull in the public key from the environment var created from the credential as it is done in the build pipeline. - Fix some bash typos and syntax errors - Use a different location for the /tmp/all-images.txt since my Jenkins user was not permitted to write to /tmp. - Add a way to provide your own list of images to verify to help debug the ec verification. - Use github url for configuration instead of a named ECP cluster record See also konflux-ci/build-definitions#1240 which back-ports one of the changes introduced here to the original source of the gather-deploy-images task. Ref: https://issues.redhat.com/browse/EC-745
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short explanation: Clean up the code a little by using a variable.
Long explanation: This task gets converted to a bash script and wrapped by a Jenkins shared library in the brand new RHTAP Jenkins pipeline sample templates. When testing the RHTAP Jenkins pipeline I found the default Jenkins user could not write to
/tmp/, so I wanted to change the location of the file. This refactor makes that just a single line change, rather than having to change the path in three places.See also
redhat-appstudio/tssc-sample-jenkins#1 where this PR was suggested by @mmorhun, and also
redhat-appstudio/tssc-dev-multi-ci#2 where the cosign, Enterprise Contract, and promote pipeline support was being added to the RHTAP Jenkins templates.