Ensure that Chains sees all image manifests referenced #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arewm
force-pushed
the
ensure-all-image-manifests-signed
branch
4 times, most recently
from
bfaaf8c to
d29cf7d
Compare
Due to a bug in Chains, it does not currently see all images produced within a matrix. In order to work around this, we can expose all images that we include in our Image Index so that Chains can generate the provenance for all of them. (and add a README for the task too) Signed-off-by: arewm <[email protected]>
arewm
force-pushed
the
ensure-all-image-manifests-signed
branch
from
d29cf7d to
d78b5e5
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in Chains, it does not currently see all images produced within a matrix. In order to work around this, we can expose all images that we include in our Image Index so that Chains can generate the provenance for all of them.
This fix is also relevant if any of the images added are themselves an image index due to tektoncd/chains#1070.
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.