Attach a patch for needed updates to the TA Tasks #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zregvart
force-pushed
the
issues/EC-769
branch
4 times, most recently
from
d6511b8 to
0544c7d
Compare
arewm
reviewed
Jul 26, 2024
| @@ -11,3 +11,9 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
| - name: Check Trusted Artifact variants | |||
| run: hack/generate-ta-tasks.sh | |||
| - name: Attach patch | |||
There was a problem hiding this comment.
Where does this attachment happen? Can you trigger a test on this PR or will the PR only use the workflows from main?
There was a problem hiding this comment.
The patch will be uploaded to GitHub and served from the "Summary" page, here is one from a previous run that I had intentionally made to fail.
There was a problem hiding this comment.
I wouldn't know to go to the Summary page. I think I'd be confused about where to get the ta.patch.
For users of the gh CLI, the message could give executable instructions:
gh run download "$GITHUB_RUN_ID" -n 'Trusted artifacts patch'
git apply ta.patch(GITHUB_RUN_ID should be injected automatically into the GH runner environment)
For others, telling them to go to the Summary page would help
When the workflow fails it should attach a patch that folk can apply to get the needed changes on their PR. Reference: https://issues.redhat.com/browse/EC-769
lcarva
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the workflow fails it should attach a patch that folk can apply to get the needed changes on their PR.
Reference: https://issues.redhat.com/browse/EC-769