Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: prefetch-deps: example of usage of configfile #1197

Merged

Conversation

MartinBasti
Copy link
Contributor

Add example how config file should be used

Before you complete this pull request ...

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

@brunoapimentel
Copy link
Contributor

Not sure if it's just for me, but when I check the README I don't see the link in available configuration parameters being rendered:
https://github.com/konflux-ci/build-definitions/blob/6d5f1541435af4b363dc3914594cfc21978abb35/task/prefetch-dependencies-oci-ta/0.1/README.md

@MartinBasti
Copy link
Contributor Author

Not sure if it's just for me, but when I check the README I don't see the link in available configuration parameters being rendered: https://github.com/konflux-ci/build-definitions/blob/6d5f1541435af4b363dc3914594cfc21978abb35/task/prefetch-dependencies-oci-ta/0.1/README.md

you are right, it worked only in my IDE :D

@MartinBasti MartinBasti force-pushed the cachi2-config-readme-example branch 2 times, most recently from 434776c to 2f029b7 Compare July 26, 2024 09:27
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one formatting issue

task/prefetch-dependencies/0.1/prefetch-dependencies.yaml Outdated Show resolved Hide resolved
Add example how config file should be used

Signed-off-by: Martin Basti <[email protected]>
@MartinBasti MartinBasti force-pushed the cachi2-config-readme-example branch from 2f029b7 to 0d0ce25 Compare July 26, 2024 10:59
@MartinBasti MartinBasti added this pull request to the merge queue Jul 26, 2024
Merged via the queue into konflux-ci:main with commit 4779a5a Jul 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants