source-build: read base image from SBOM #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmeliik
force-pushed
the
sourcebuild-get-base-images-from-sboms
branch
2 times, most recently
from
8839358 to
e3ced4f
Compare
chmeliik
force-pushed
the
sourcebuild-get-base-images-from-sboms
branch
from
e3ced4f to
75adfb1
Compare
/retest |
again 😞 |
|
no idea |
chmeliik
force-pushed
the
sourcebuild-get-base-images-from-sboms
branch
from
75adfb1 to
03822ff
Compare
|
Rebased on main. That should fix it 🤦 |
mmorhun
approved these changes
Jul 12, 2024
chmeliik
force-pushed
the
sourcebuild-get-base-images-from-sboms
branch
from
03822ff to
f00fdae
Compare
|
/retest |
tkdchen
reviewed
Jul 15, 2024
chmeliik
force-pushed
the
sourcebuild-get-base-images-from-sboms
branch
from
f00fdae to
c9c3918
Compare
STONEBLD-2607 When the BASE_IMAGES param is empty, fall back to reading the base image from the SBOM of the BINARY_IMAGE. This removes the source-build task's dependency on the BASE_IMAGES_DIGESTS result, finally allowing us to stop returning this result from build tasks. Signed-off-by: Adam Cmiel <[email protected]>
chmeliik
force-pushed
the
sourcebuild-get-base-images-from-sboms
branch
from
c9c3918 to
89ed04c
Compare
|
Re-generated the oci-ta variant |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STONEBLD-2607
When the BASE_IMAGES param is empty, fall back to reading the base image from the SBOM of the BINARY_IMAGE.
This removes the source-build task's dependency on the BASE_IMAGES_DIGESTS result, finally allowing us to stop returning this result from build tasks.
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.