Combine three bundle build tasks into one #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The diff is not easy to review by eye, but I like the concept. If this can solve or even reduce the frequency of the intermittent failures described in EC-705 that would be fantastic. |
chmeliik
reviewed
Jul 4, 2024
chmeliik
reviewed
Jul 4, 2024
Seems that scheduling Task pods often runs into issues, most likely the inability to mount persistent volumes caused by "volume node affinity conflict". To minimize this issue three separate bundle build Tasks are now combined into a single Tasks as three Steps instead. Reference: https://issues.redhat.com/browse/EC-705 Co-authored-by: Adam Cmiel <[email protected]>
chmeliik
approved these changes
Jul 4, 2024
|
Thanks for the review, I'll start the merge now and watch out for any issues. |
|
This is caused by the commit not containing any changes to the Tasks. I'll create a followup PR to ignore missing task bundle list files |
zregvart
added a commit
to zregvart/build-definitions
that referenced
this pull request
Jul 4, 2024
Follow up to konflux-ci#1112, let's not confuse folk by printing: ``` cat: /workspace/source/task-bundle-list-konflux-ci: No such file or directory cat: /workspace/source/task-bundle-list-appstudio: No such file or directory ``` In the TaskRun logs. Those files do not exist if no Tasks were changed. Reference: https://issues.redhat.com/browse/EC-705
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 6, 2024
Follow up to #1112, let's not confuse folk by printing: ``` cat: /workspace/source/task-bundle-list-konflux-ci: No such file or directory cat: /workspace/source/task-bundle-list-appstudio: No such file or directory ``` In the TaskRun logs. Those files do not exist if no Tasks were changed. Reference: https://issues.redhat.com/browse/EC-705
jduimovich
pushed a commit
to jduimovich/build-definitions
that referenced
this pull request
Aug 6, 2024
Follow up to konflux-ci#1112, let's not confuse folk by printing: ``` cat: /workspace/source/task-bundle-list-konflux-ci: No such file or directory cat: /workspace/source/task-bundle-list-appstudio: No such file or directory ``` In the TaskRun logs. Those files do not exist if no Tasks were changed. Reference: https://issues.redhat.com/browse/EC-705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that scheduling Task pods often runs into issues, most likely the inability to mount persistent volumes caused by "volume node affinity conflict". To minimize this issue three separate bundle build Tasks are now combined into a single Tasks as three Steps instead.
Reference: https://issues.redhat.com/browse/EC-705