Remove the squash_all parameter #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got confused before. `podman build` has both a `--squash` and a `--squash-all` option. `buildah build` has only a `--squash` option which behaves like the `--squash-all` option from `podman build`. We _just_ added this param earlier this morning. Hopefully we can remove it here without needing a task version bump.
chmeliik
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got confused before in #1107
podman buildhas both a--squashand a--squash-alloption.buildah buildhas only a--squashoption which behaves like the--squash-alloption frompodman build.We just added this param earlier this morning. Hopefully we can remove it here without needing a task version bump.