Support netrc auth for prefetch-dependencies #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/containerbuildsystem/cachi2/releases/tag/0.8.0 Signed-off-by: Adam Cmiel <[email protected]>
Allow user to supply a workspace containing a .netrc file. Cachi2 will authenticate https requests using the credentials in this file. Signed-off-by: Adam Cmiel <[email protected]>
In the PipelineRun template, the users are going to pass the workspace
with something like this
workspaces:
- name: netrc
secret:
secretName: my-netrc
Signed-off-by: Adam Cmiel <[email protected]>
|
/retest |
|
Tested in acmiel-rhtap/cachi2-pip-custom-index#1 The index server defined in https://github.com/acmiel-rhtap/cachi2-pip-custom-index/blob/main/requirements.txt requires auth, which was provided from a netrc secret in my workspace |
MartinBasti
approved these changes
Jun 27, 2024
rcerven
approved these changes
Jun 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STONEBLD-2506