Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eaas-provision-space task #1064

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

amisstea
Copy link
Contributor

@amisstea amisstea commented Jun 9, 2024

This task is meant to be used before all other EaaS tasks/stepactions in a pipeline (such as #1058).

Signed-off-by: Alex Misstear <[email protected]>
@amisstea
Copy link
Contributor Author

amisstea commented Jun 9, 2024

@oamsalem @yftacherzog please review.

Copy link
Member

@yftacherzog yftacherzog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amisstea
Copy link
Contributor Author

/retest

@amisstea
Copy link
Contributor Author

@konflux-ci/build-maintainers can I please get your approval on this PR?

Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have the context for EaaS, but the code looks reasonable 👍

@amisstea
Copy link
Contributor Author

@chmeliik, if you have the permission, can you please merge this?

@chmeliik chmeliik added this pull request to the merge queue Jun 19, 2024
Merged via the queue into konflux-ci:main with commit db47b33 Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants