Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(STONEBLD-2496, KFLUXBUGS-1317) Ensure that the base image digest result is present #1056

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

arewm
Copy link
Member

@arewm arewm commented Jun 5, 2024

If there is no base image (i.e. if the image is only FROM scratch), then the file will not be present and therefore step-create-base-images-sbom will fail.

Resolves: https://issues.redhat.com/browse/STONEBLD-2496
Resolves: https://issues.redhat.com/browse/KFLUXBUGS-1317

@arewm
Copy link
Member Author

arewm commented Jun 5, 2024

This PR will need to modify the code added from #1044 after that merges. Done

@arewm arewm requested review from mmorhun and chmeliik June 5, 2024 20:04
…result is present

If there is no base image (i.e. if the image is only FROM scratch), then
the file will not be present and therefore step-create-base-images-sbom
will fail.

Resolves: https://issues.redhat.com/browse/STONEBLD-2496
Resolves: https://issues.redhat.com/browse/KFLUXBUGS-1317

Signed-off-by: arewm <[email protected]>
@arewm arewm force-pushed the fix-sbom-scratch branch from d9798c4 to a2d37bc Compare June 6, 2024 04:12
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chmeliik chmeliik added this pull request to the merge queue Jun 6, 2024
Merged via the queue into konflux-ci:main with commit 5c17d3d Jun 6, 2024
2 checks passed
@arewm arewm deleted the fix-sbom-scratch branch June 6, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants