fix(KFLUXBUGS-1328): pull secrets in rpm-ostree #1054
Conversation
scoheb
commented
Jun 5, 2024
•
scoheb
commented
- copy functionality used in buildah-remote task
- copy functionality used in buildah-remote task Signed-off-by: Scott Hebert <[email protected]>
| @@ -173,6 +174,7 @@ spec: | |||
| -e COMMIT_SHA="$COMMIT_SHA" \ | |||
| --rm \ | |||
| -v "$BUILD_DIR/workspaces/source:$(workspaces.source.path):Z" \ | |||
| -v "$BUILD_DIR/.docker/:/root/.docker:Z" \ | |||
There was a problem hiding this comment.
I'm a bit confused by this one, is it really necessary? It seems to expose the pull secret to the container itself, but I don't think we need that here FWIW.
There was a problem hiding this comment.
Oh good catch, this is a different use case than the buildah-remote task. This one wants to use the credentials to pull the BUILDER_IMAGE itself, and there's no need to pass the credentials to that image again
I think we need to rsync the docker credentials to the $HOME of the VM user
There was a problem hiding this comment.
You need to either sync the credentials to the $HOME/.docker dir, or explicitly tell podman which credentials file to use.
|
There's a more medium term thing here that I think we can actually kill the rpm-ostree task in favor of buildah-remote. |
| @@ -173,6 +174,7 @@ spec: | |||
| -e COMMIT_SHA="$COMMIT_SHA" \ | |||
| --rm \ | |||
| -v "$BUILD_DIR/workspaces/source:$(workspaces.source.path):Z" \ | |||
| -v "$BUILD_DIR/.docker/:/root/.docker:Z" \ | |||
There was a problem hiding this comment.
You need to either sync the credentials to the $HOME/.docker dir, or explicitly tell podman which credentials file to use.
|
This PR is a blocker for a downstream MR. Would you be able to prioritize this? |
|
looks abandoned, can we close this? |
|
Yep. We can close. |
