Sync entitlement secret #1050
Closed
Sync entitlement secret #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
force-pushed
the
sync-entititlement-secret
branch
from
bacbd47 to
569567f
Compare
gbenhaim
approved these changes
Jun 3, 2024
gbenhaim
reviewed
Jun 3, 2024
| @@ -189,6 +189,8 @@ spec: | |||
| fi | |||
|
|
|||
| rsync -ra $(workspaces.source.path)/ "$SSH_HOST:$BUILD_DIR/workspaces/source/" | |||
| rsync -ra /entitlement/ "$SSH_HOST:$BUILD_DIR/volumes/etc-pki-entitlement/" | |||
| rsync -ra /mnt/trusted-ca/ "$SSH_HOST:$BUILD_DIR/volumes/trusted-ca/" | |||
There was a problem hiding this comment.
will it still work if /mnt/trusted-ca doesn't exist? mounting the configmap to that directory is optional and only happens with the configmap with the ca bundle is configured in the namespace.
There was a problem hiding this comment.
Sorry, I forgot to respond to this. I tested it locally and it seemed to work fine.
stuartwdouglas
force-pushed
the
sync-entititlement-secret
branch
from
569567f to
6cd9245
Compare
gbenhaim
approved these changes
Jun 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
/test buildah-remote |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@stuartwdouglas why did you close this one? is there another pr for making those changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.