-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker-build-oci-ta Pipeline #1024
Conversation
I'll likely have to adjust this once #1022 is merged. |
Moving this to draft because there are two gaps here:
|
Ready for review. We decided that the summary Task doesn't provide a whole lot of value. We will exclude it from the (Also, if you do think we should include the summary Task in this new Pipeline, let me know!) |
8423d32
to
eb8f827
Compare
Quality Gate passedIssues Measures |
@mmorhun, could you please create the |
name: CACHI2_ARTIFACT | ||
value: $(tasks.prefetch-dependencies.results.CACHI2_ARTIFACT) | ||
- op: remove | ||
path: /spec/tasks/4/workspaces/0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you consider removing the whole thing when you expect it to be empty afterwards?
path: /spec/tasks/4/workspaces/0 | |
path: /spec/tasks/4/workspaces |
Just an idea for tidier yaml - I don't think it would make any functional difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
..and of course you can't do that for the tasks with the git-auth workspace..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna leave it as is for consistency. The empty array is not a big deal.
I did this to compare the old/new:
Looks nice and tidy except I guess for the |
/retest |
This Pipeline, based on the docker-build Pipeline, uses Trusted Artifacts stored in an OCI registry to share data between Tasks. No PVC is needed. Ref: EC-555 Signed-off-by: Luiz Carvalho <[email protected]>
/retest |
CI is failing here with an odd error:
I can reproduce the issue locally with |
/retest |
/lgtm |
This Pipeline, based on the docker-build Pipeline, uses Trusted Artifacts stored in an OCI registry to share data between Tasks. No PVC is needed.
Ref: EC-555
Before you complete this pull request ...
Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.