Add the new git-clone-oci-ta Task #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tip for reviewers: the first commit in this PR is a plain copy of the |
lcarva
commented
May 10, 2024
lcarva
commented
May 10, 2024
simonbaird
reviewed
May 13, 2024
simonbaird
reviewed
May 13, 2024
simonbaird
approved these changes
May 13, 2024
chmeliik
reviewed
May 14, 2024
This commit creates a copy of the git-clone directory in the git-clone-oci-ta directory. This is done to make it easier to review the corresponding changes to support Trusted Artifacts. Signed-off-by: Luiz Carvalho <[email protected]>
Signed-off-by: Luiz Carvalho <[email protected]>
lcarva
force-pushed
the
EC-550
branch
2 times, most recently
from
0b8db1c to
96de586
Compare
Ref: EC-550 Co-authored-by: Zoran Regvart <[email protected]> Signed-off-by: Luiz Carvalho <[email protected]>
|
|
/retest |
|
/retest Seems like an unrelated issue: |
|
/retest |
|
Side note: these changes should have no impact on the existing tasks and pipelines. e2e-tests errors are likely unrelated. |
|
/retest |
|
Weird e2e failure... We should probably just merge this PR as is. I can't think of how adding a new Task would cause issues on that test |
|
I'm force merging this after Luiz pinged me about it. Neither of us could reason that adding a new task would cause CI to fail in that way. Build team - if you would rather I not use admin powers to do this in the future, please reach out and let me know and I'll adjust. |
|
FWIW, the e2e-tests failures seem to be due to too many secrets linked to the ServiceAccount: I was able to get this in Splunk from one of the Tasks in the failing test pipeline: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Tekton Task,
git-clone-oci-ta. This is a variation of the0.1/git-cloneTask. The main difference is that instead of cloning to a workspace, this Task stores the cloned repository as a Trusted Artifact in an OCI registry.The Task is not currently used in any of the default Pipelines. This will happen later on.
I tested this Task on a kind cluster like this:
Resolves EC-550