Skip to content

Commit

Permalink
Removes unused workdir volume form oci-copy Task
Browse files Browse the repository at this point in the history
There is no volumeMount for workdir in the oci-copy task, and it's
presence in the volumes causes duplicate volumes in the oci-copy-oci-ta
Task.

This could also be resolved by making the generator aware of duplicate
volumes and volumeMounts. Let's do that if it indeed does become an
issue.
  • Loading branch information
zregvart committed Sep 16, 2024
1 parent a27148f commit 3f3d079
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions task/oci-copy-oci-ta/0.1/oci-copy-oci-ta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ spec:
emptyDir: {}
- name: workdir
emptyDir: {}
- name: workdir
emptyDir: {}
stepTemplate:
env:
- name: IMAGE
Expand Down
2 changes: 0 additions & 2 deletions task/oci-copy/0.1/oci-copy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -318,8 +318,6 @@ spec:
volumes:
- emptyDir: {}
name: varlibcontainers
- emptyDir: {}
name: workdir
workspaces:
- description: Workspace containing the source artifacts to copy
name: source

0 comments on commit 3f3d079

Please sign in to comment.