Skip to content

Commit

Permalink
Provide non-empty default for bearer token secret
Browse files Browse the repository at this point in the history
If empty, then the pod will try to access the empty-string secret which
results in pipeline failure.

If this non-sense value is provided, then the pipeline will proceed.

An alternative could be to make this param required instead of optional.
  • Loading branch information
ralphbean authored and chmeliik committed Jul 9, 2024
1 parent b70abf2 commit 25d5de7
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion task/oci-copy-oci-ta/0.1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Given a file in the user's source directory, copy content from arbitrary urls in
## Parameters
|name|description|default value|required|
|---|---|---|---|
|BEARER_TOKEN_SECRET_NAME|Name of a secret which will be made available to the build as an Authorization header. Note, the token will be sent to all servers found in the oci-copy.yaml file. If you do not wish to send the token to all servers, different taskruns and therefore different oci artifacts must be used.|""|false|
|BEARER_TOKEN_SECRET_NAME|Name of a secret which will be made available to the build as an Authorization header. Note, the token will be sent to all servers found in the oci-copy.yaml file. If you do not wish to send the token to all servers, different taskruns and therefore different oci artifacts must be used.|does-not-exist|false|
|IMAGE|Reference of the image we will push||true|
|OCI_COPY_FILE|Path to the oci copy file.|./oci-copy.yaml|false|
|SOURCE_ARTIFACT|The Trusted Artifact URI pointing to the artifact with the application source code.||true|
Expand Down
2 changes: 1 addition & 1 deletion task/oci-copy-oci-ta/0.1/oci-copy-oci-ta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spec:
to all servers, different taskruns and therefore different oci artifacts
must be used.
type: string
default: ""
default: does-not-exist
- name: IMAGE
description: Reference of the image we will push
type: string
Expand Down
2 changes: 1 addition & 1 deletion task/oci-copy/0.1/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Note: the bearer token secret, if specified, will be sent to **all servers liste
|---|---|---|---|
|IMAGE|Reference of the image buildah will produce.||true|
|OCI_COPY_FILE|Path to the oci copy file.|./oci-copy.yaml|false|
|BEARER_TOKEN_SECRET_NAME|Name of a secret which will be made available to the build as an Authorization header. Note, the token will be sent to all servers found in the oci-copy.yaml file. If you do not wish to send the token to all servers, different taskruns and therefore different oci artifacts must be used.|""|false|
|BEARER_TOKEN_SECRET_NAME|Name of a secret which will be made available to the build as an Authorization header. Note, the token will be sent to all servers found in the oci-copy.yaml file. If you do not wish to send the token to all servers, different taskruns and therefore different oci artifacts must be used.|"does-not-exist"|false|


## Results
Expand Down
2 changes: 1 addition & 1 deletion task/oci-copy/0.1/oci-copy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ spec:
be sent to all servers found in the oci-copy.yaml file. If you do not wish to send the token to all servers,
different taskruns and therefore different oci artifacts must be used.
type: string
default: ""
default: "does-not-exist"
results:
- description: Digest of the artifact just pushed
name: IMAGE_DIGEST
Expand Down

0 comments on commit 25d5de7

Please sign in to comment.