Skip to content

Commit

Permalink
Support prefetch-dependencies without hermetic
Browse files Browse the repository at this point in the history
IIUC there is some value in doing a prefetch-dependencies even if
you're not quite ready to enable a hermetic build. This change makes
it easier and more intuitive for people who want to do that.

For a pipeline with a non-empty value for prefetch-input, let's
assume that the intention is to run the prefetch-dependencies task.

(This is a fast patch for an idea that occurred to me while working
on https://issues.redhat.com/browse/EC-585 . Not sure how/where to
test it. If the idea seems reasonable I'd be happy to create a fresh
Jira for it and take some advice on what kind of testing it should
have.)
  • Loading branch information
simonbaird committed Apr 24, 2024
1 parent f58ba64 commit 1bc8564
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions pipelines/template-build/template-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,8 @@ spec:
workspace: git-auth
- name: prefetch-dependencies
when:
- input: $(params.hermetic)
operator: in
values: ["true"]
- cel: >-
'$(params.prefetch-input) != '' || '$(params.hermetic)' == 'true'
params:
- name: input
value: $(params.prefetch-input)
Expand Down

0 comments on commit 1bc8564

Please sign in to comment.