Skip to content

Commit

Permalink
add bash problem to buildah.yaml
Browse files Browse the repository at this point in the history
While at the same time, fixing another problem by using a more accurate
shebang

Signed-off-by: Adam Cmiel <[email protected]>
  • Loading branch information
chmeliik committed Jul 12, 2024
1 parent 3dd6dc0 commit 020fd2f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion task/buildah/0.1/buildah.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ spec:
args:
- $(params.BUILD_ARGS[*])
script: |
#!/bin/bash
set -e
if [ -n "${PARAM_BUILDER_IMAGE}" ]; then
echo "WARNING: provided deprecated BUILDER_IMAGE parameter has no effect."
fi
Expand Down Expand Up @@ -308,7 +310,7 @@ spec:
unshare -Uf $UNSHARE_ARGS --keep-caps -r --map-users 1,1,65536 --map-groups 1,1,65536 -w ${SOURCE_CODE_DIR}/$CONTEXT -- buildah build \
$VOLUME_MOUNTS \
"${BUILDAH_ARGS[@]}" \
${BUILDAH_ARGS[@]} \

Check failure

Code scanning / shellcheck

SC2068 Error

Double quote array expansions to avoid re-splitting elements.
"${LABELS[@]}" \
--tls-verify=$TLSVERIFY --no-cache \
--ulimit nofile=4096:4096 \
Expand Down

0 comments on commit 020fd2f

Please sign in to comment.