Add simple examples and reference numpy scripts #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,6 +4,9 @@ project(kokkos-fft LANGUAGES CXX) | |||
| # Add cmake helpers for FFTW | |||
| list(INSERT CMAKE_MODULE_PATH 0 "${CMAKE_SOURCE_DIR}/cmake") | |||
|
|
|||
| # Options | |||
| option(BUILD_EXAMPLES "Build kokkos-fft examples" ON) | |||
|
|
|||
| find_package(Kokkos CONFIG) | |||
| if(NOT kokkos_FOUND) | |||
There was a problem hiding this comment.
Are you sure about the case ?
Suggested change
| if(NOT kokkos_FOUND) | |
| if(NOT Kokkos_FOUND) |
| @@ -4,6 +4,9 @@ project(kokkos-fft LANGUAGES CXX) | |||
| # Add cmake helpers for FFTW | |||
| list(INSERT CMAKE_MODULE_PATH 0 "${CMAKE_SOURCE_DIR}/cmake") | |||
|
|
|||
| # Options | |||
| option(BUILD_EXAMPLES "Build kokkos-fft examples" ON) | |||
|
|
|||
| find_package(Kokkos CONFIG) | |||
There was a problem hiding this comment.
Are you sure it's a good idea to limit to CONFIG?
Some application might have valid reasons to have a custom FindKokkos.cmake.
| @@ -0,0 +1,2 @@ | |||
| add_executable(01_1DFFT 01_1DFFT.cpp) | |||
| target_link_libraries(01_1DFFT PUBLIC Kokkos::fft) | |||
There was a problem hiding this comment.
Perhaps we can add examples to be run as tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a preparation for docs, small examples are added.
Each example includes Kokkos and numpy implementations. For example,
01_1DFFTincludes,*.cppexample is the Kokkos implementation of the numpy script. The backend is chosen based on your choice of compile option for Kokkos,-DKokkos_ENABLE_OPENMP=ONforOpenMPbackend, for example.