Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Kokkos::Profiling::Region to profile tpl calls #204

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Introduce Kokkos::Profiling::Region to profile tpl calls #204

wants to merge 3 commits into from

Conversation

yasahi-hpc
Copy link
Collaborator

@yasahi-hpc yasahi-hpc commented Nov 28, 2024 •
edited
Loading

Resolves #201

In this PR, we introduce Kokkos::Profiling::pushRegion Kokkos::Profiling::ScopedRegion to profile the timings of tpl calls.

@yasahi-hpc yasahi-hpc self-assigned this Nov 28, 2024
@yasahi-hpc yasahi-hpc added the enhancement New feature or request label Nov 28, 2024
dalg24
dalg24 reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at all the changes but the one I saw were a better fit for Kokkos::Profiling::ScopedRegion

@yasahi-hpc
Copy link
Collaborator Author

I didn't look at all the changes but the one I saw were a better fit for Kokkos::Profiling::ScopedRegion

Thank you for the comments. I was not aware of this.
Clearly, this is what I need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@yasahi-hpc yasahi-hpc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce regions for better profiling with kokkos-tools
2 participants
@yasahi-hpc @dalg24