Pass views by const& in fftshift

[tpadioleau]

Fixes #191

[yasahi-hpc]

Thanks, LGTM
Recently, we express the unused variable as a comment.

[tpadioleau]

Thanks, LGTM Recently, we express the unused variable as a comment.

There is clang-tidy check to detect unnamed parameters if you want to enforce this rule.

[yasahi-hpc]

Thanks, LGTM Recently, we express the unused variable as a comment.

There is clang-tidy check to detect unnamed parameters if you want to enforce this rule.

This one?
https://clang.llvm.org/extra/clang-tidy/checks/readability/named-parameter.html

I will certainly add this rule

[tpadioleau]

This one? https://clang.llvm.org/extra/clang-tidy/checks/readability/named-parameter.html

I will certainly add this rule

Yes that is it

[yasahi-hpc]

I added fixes #191 in order to close the issue as soon as this PR is merged