Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add traits to help type checks #117

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Add traits to help type checks #117

merged 4 commits into from
Jul 12, 2024

Conversation

yasahi-hpc
Copy link
Collaborator

This PR aims at moving traits into KokkosFFT_traits.hpp from KokkosFFT_utils.hpp.
This will be applied in another PR to improve error handlings as commented in #80

Following modifications are made

  1. All traits are moved into KokkosFFT_traits.hpp
  2. Traits are still included via KokkosFFT_utils.hpp
  3. Add compile tests for traits Test_Traits.hpp

@yasahi-hpc yasahi-hpc self-assigned this Jul 9, 2024
@yasahi-hpc yasahi-hpc added enhancement New feature or request cleanup labels Jul 9, 2024
@cedricchevalier19
Copy link
Member

@yasahi-hpc I will look at it tomorrow; I still remember.

cedricchevalier19
cedricchevalier19 reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should comment on the goal of the different traits.

Do you plan to use concepts later?

common/src/KokkosFFT_traits.hpp Outdated Show resolved Hide resolved
@yasahi-hpc
Copy link
Collaborator Author

I think you should comment on the goal of the different traits.

Do you plan to use concepts later?

Sure. I will add comments
I would like to introduce concepts as soon as Kokkos moves to C++20

@yasahi-hpc
Copy link
Collaborator Author

@cedricchevalier19 Thank you for your reviews. I will merge this

@yasahi-hpc yasahi-hpc merged commit 0e29048 into kokkos:main Jul 12, 2024
19 checks passed
@yasahi-hpc yasahi-hpc deleted the add-traits branch July 12, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedricchevalier19 cedricchevalier19 cedricchevalier19 approved these changes

Assignees

@yasahi-hpc yasahi-hpc

Labels
cleanup enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yasahi-hpc @cedricchevalier19