Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename: KokkosFFT_OpenMP*.hpp to KokkosFFT_Host*.hpp for fftw backend #114

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

yasahi-hpc
Copy link
Collaborator

Resolves #110

Renaming files for fftw backend:

 rename fft/src/{KokkosFFT_OpenMP_plans.hpp => KokkosFFT_Host_plans.hpp} (98%)
 rename fft/src/{KokkosFFT_OpenMP_transform.hpp => KokkosFFT_Host_transform.hpp} (94%)
 rename fft/src/{KokkosFFT_OpenMP_types.hpp => KokkosFFT_Host_types.hpp} (97%)

@yasahi-hpc yasahi-hpc self-assigned this Jul 5, 2024
@jbigot
Copy link
Member

jbigot commented Jul 5, 2024

is it host or parallel-host? By that I mean: is there a separate set of files for host serial?

@cedricchevalier19
Copy link
Member

@jbigot, I think it is from #109; I saw that the OpenMP files are also for Threads and Serial backends.

@jbigot
Copy link
Member

jbigot commented Jul 5, 2024

I see, then it sounds good

@yasahi-hpc
Copy link
Collaborator Author

@jbigot

is it host or parallel-host? By that I mean: is there a separate set of files for host serial?

As @cedricchevalier19 said, this handles all host backends, so Host should be a better name.
In the current implementation, the only difference between parallel_host and host is the call of init_threads for fftw or not

@yasahi-hpc yasahi-hpc merged commit f49a2e8 into kokkos:main Jul 5, 2024
19 checks passed
@yasahi-hpc yasahi-hpc deleted the rename-fftw-backend branch July 5, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename KokkosFFT_OpenMP_*.hpp to KokkosFFT_Host_*.hpp
3 participants