Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up some warnings and enabling -Werror on Intel GPU CI tests #112

Merged
merged 6 commits into from
Jul 5, 2024

Conversation

yasahi-hpc
Copy link
Collaborator

@yasahi-hpc yasahi-hpc commented Jul 4, 2024

Resolves #106.

  • Cleaning icpx warnings on Intel GPUs
  • Enabling warnings, but cannot use -Werror because there are already many warnings from Kokkos

@yasahi-hpc yasahi-hpc self-assigned this Jul 4, 2024
Copy link
Member

@cedricchevalier19 cedricchevalier19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An external Kokkos build may avoid warnings from Kokkos (by using -isystem).

Anyway it is a great improvement.

@yasahi-hpc
Copy link
Collaborator Author

An external Kokkos build may avoid warnings from Kokkos (by using -isystem).

Anyway it is a great improvement.

Thank you for your review.
So we need to modify CMake a little bit?

The easiest way may be to do the build test with -Werror option using the preinstalled Kokkos
I will do that in another PR

@yasahi-hpc yasahi-hpc merged commit 04c180e into kokkos:main Jul 5, 2024
15 of 19 checks passed
@yasahi-hpc yasahi-hpc deleted the warnings-icpx branch July 5, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stricter checks in the CI
2 participants