clang tidy in CI

.clang-tidy

@@ -0,0 +1,8 @@
+# SPDX-FileCopyrightText: (C) The Kokkos-FFT development team, see COPYRIGHT.md file
+#
+# SPDX-License-Identifier: MIT OR Apache-2.0 WITH LLVM-exception
+
+Checks: '-*,kokkos-*,modernize-type-traits,modernize-use-using,modernize-use-nullptr,cppcoreguidelines-pro-type-cstyle-cast'
+FormatStyle: file
+HeaderFilterRegex: '(common|fft).*\.hpp'
+ExcludeHeaderFilterRegex: '(tpls).*\.hpp'

.github/workflows/__build_base.yaml

@@ -37,6 +37,8 @@ jobs:
         image:
           - name: gcc
             use_singularity: false
+          - name: clang
+            use_singularity: false
           - name: nvcc
             use_singularity: true
           - name: rocm

.github/workflows/build_test.yaml

@@ -66,6 +66,15 @@ jobs:
     strategy:
       matrix:
         backend:
+          - name: clang-tidy
+            image: clang
+            compiler:
+              c: clang
+              cxx: clang++
+            cmake_flags:
+              cxx_standard: 17
+              kokkos: -DKokkos_ENABLE_OPENMP=ON
+              kokkos_fft: -DCMAKE_CXX_FLAGS="-Wall -Wextra" -DCMAKE_COMPILE_WARNING_AS_ERROR=ON -DCMAKE_CXX_CLANG_TIDY="clang-tidy;-warnings-as-errors=*"
           - name: openmp
             image: gcc
             compiler:
@@ -137,6 +146,10 @@ jobs:
           - name: host_device
             cmake_flags: -DKokkosFFT_ENABLE_HOST_AND_DEVICE=ON
         exclude:
+          - backend:
+              name: clang-tidy
+            target:
+              name: host_device
           - backend:
               name: openmp
             target:

.github/workflows/cleanup_base.yaml

@@ -31,5 +31,7 @@ jobs:
             kokkos-fft/base_rocm_pr
             kokkos-fft/base_gcc_main
             kokkos-fft/base_gcc_pr
+            kokkos-fft/base_clang_main
+            kokkos-fft/base_clang_pr
             kokkos-fft/base_intel_main
             kokkos-fft/base_intel_pr

docker/clang/Dockerfile

@@ -0,0 +1,67 @@
+# SPDX-FileCopyrightText: (C) The Kokkos-FFT development team, see COPYRIGHT.md file
+#
+# SPDX-License-Identifier: MIT OR Apache-2.0 WITH LLVM-exception
+
+ARG BASE=ubuntu:latest
+FROM $BASE
+
+ENV DEBIAN_FRONTEND=noninteractive
+RUN apt-get update && apt-get install -y \
+        build-essential \
+        wget \
+        gnupg \
+        lsb-release \
+        software-properties-common \
+        git \
+        bc \
+        ccache \
+        libfftw3-dev \
+        && \
+    apt-get clean && \
+    rm -rf /var/lib/apt/lists/*
+
+ENV FFTWDIR "/usr"
+
+RUN git config --global --add safe.directory "*"
+
+# Add the official LLVM repository to install Clang and Clang-tidy version 19
+RUN wget https://apt.llvm.org/llvm.sh && \
+    chmod +x llvm.sh && \
+    ./llvm.sh 19
+
+# Install Clang++ version 19 and Clang-tidy version 19
+RUN apt-get update && apt-get install -y \
+    clang-19 \
+    clang-tidy-19 \
+    && rm -rf /var/lib/apt/lists/*
+
+RUN KEYDUMP_URL=https://cloud.cees.ornl.gov/download && \
+    KEYDUMP_FILE=keydump && \
+    wget --quiet ${KEYDUMP_URL}/${KEYDUMP_FILE} && \
+    wget --quiet ${KEYDUMP_URL}/${KEYDUMP_FILE}.sig && \
+    gpg --import ${KEYDUMP_FILE} && \
+    gpg --verify ${KEYDUMP_FILE}.sig ${KEYDUMP_FILE} && \
+    rm ${KEYDUMP_FILE}*
+
+ARG CMAKE_VERSION=3.23.2
+ENV CMAKE_DIR=/opt/cmake
+RUN CMAKE_URL=https://github.com/Kitware/CMake/releases/download/v${CMAKE_VERSION} && \
+    CMAKE_SCRIPT=cmake-${CMAKE_VERSION}-Linux-x86_64.sh && \
+    CMAKE_SHA256=cmake-${CMAKE_VERSION}-SHA-256.txt && \
+    wget --quiet ${CMAKE_URL}/${CMAKE_SHA256} && \
+    wget --quiet ${CMAKE_URL}/${CMAKE_SHA256}.asc && \
+    wget --quiet ${CMAKE_URL}/${CMAKE_SCRIPT} && \
+    gpg --verify ${CMAKE_SHA256}.asc ${CMAKE_SHA256} && \
+    grep -i ${CMAKE_SCRIPT} ${CMAKE_SHA256} | sed -e s/linux/Linux/ | sha256sum --check && \
+    mkdir -p ${CMAKE_DIR} && \
+    sh ${CMAKE_SCRIPT} --skip-license --prefix=${CMAKE_DIR} && \
+    rm cmake*
+ENV PATH=${CMAKE_DIR}/bin:$PATH
+
+# Set Clang 19 as the default Clang and Clang++
+RUN update-alternatives --install /usr/bin/clang clang /usr/bin/clang-19 100 \
+    && update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-19 100 \
+    && update-alternatives --install /usr/bin/clang-tidy clang-tidy /usr/bin/clang-tidy-19 100
+
+WORKDIR /work
+CMD ["bash"]