Cleanup contexts #309
Merged
Cleanup contexts #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ossip is disabled and pass contexts in to calls where applicable
mvandeberg
force-pushed
the
304-cleanup-contexts
branch
from
aeb350b to
fd40ce2
Compare
sgerbino
previously approved these changes
Nov 14, 2024
mvandeberg
dismissed
sgerbino’s stale review
The merge-base changed after approval.
sgerbino
approved these changes
Nov 14, 2024
sgerbino
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #304
Brief description
Cleans up use of contexts to avoid leaking go routines when gossip is disabled or peers disconnect.
Checklist
Demonstration