Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade formidable to ^3.2.4 to address CVE-2022-29622 #205

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ankit-github
Copy link

No description provided.

@alexandrebodin
Copy link

Would really like to see this getting merged at some point @MarkHerhold :) Can we help somehow?

@MarkHerhold
Copy link
Contributor

Hi there, we only declare that we require "formidable": "^2.0.1" (meaning all version 2's) in package.json and this upgrades us to formidable version 3. The CVE mentioned in the title states that the affected version is 3.1.4.

Furthermore, tests are failing. It looks like this team had to deal with the same issue.

npm t

> [email protected] test
> mocha test/unit/

internal/modules/cjs/loader.js:1102
      throw new ERR_REQUIRE_ESM(filename, parentPath, packageJsonPath);
      ^

Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /Users/Mark/projects/koa-body/node_modules/formidable/src/index.js
require() of ES modules is not supported.

@alexandrebodin
Copy link

Indeed, I was looking for koa-body to support the v2 for formidable but you have a release on npm just didn't see it in the changelogs and github releases. Thanks for the quick reply 👍

@alexandrebodin
Copy link

alexandrebodin commented Aug 11, 2022

Actually @MarkHerhold Do you have a changelog for the v5 lying around?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants