Migrate database to UTF-8 collation and update project documentation #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change sets MSSQL 2019 as the minimum SQL Server version. For older versions, the collation can be reverted to `SQL_Latin1_General_CP1_CI_AS` by modifying the `import.ps1` script. However, UTF-8 compatibility is required for proper functionality. UTF-8 ensures consistent behavior regardless of the host system's settings. On Unix, UTF-8 is typically enabled by default. On Windows, it can be enabled under Region settings with "Beta: Use Unicode UTF-8 for worldwide language support." For details, see this discussion: ko4life-net/ko#260 (comment)
Note that we decided to set strFile as varchar instead of nvarchar because of the newly updated UTF-8 compatible collation.
Formatting migration scripts is now optional. While formatting is helpful for table creation or altering procedures, it can be cumbersome for large insert queries. Therefore, automatic formatting has been disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to modernize the database setup, improve compatibility, and reflect the current state of the project:
Update Database Collation:
Latin1_General_100_CS_AS_SC_UTF8collation, requiring MSSQL 2019 as the minimum supported version.SQL_Latin1_General_CP1_CI_ASby modifying theimport.ps1script. Note that UTF-8 compatibility is necessary for proper functionality.Adjust
VERSIONTable:VERSIONtable to match recent changes inLoginServer.strFiletoVARCHARinstead ofNVARCHARdue to the new UTF-8-compatible collation.Update Documentation:
README.mdfile to reflect the current state of the project and provide accurate setup instructions.Notes