fix UB in Daemonize::privileged_action #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes UB in
Daemonize::privileged_action
by removing the transmute fromDaemonize<T>
toDaemonize<N>
.Transmuting between
Daemonize<T>
andDaemonize<N>
is not guaranteed to be valid, as the transmute may temporarily putself.privileged_action
into an invalid state.The type layout of
Daemonize<T>
andDaemonize<N>
are also not guaranteed to be equivalent, since the compiler may reorder the fields of different instances of the same generic type according to the Transmutes section of the Rustonomicon.The solution used is to construct a
Daemonize<N>
manually and fill in the common fields fromself
, rather than transmuting and replacing just theprivileged_action
field.